Rule: sprintf-arguments-mismatch
#1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1009 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
reviewed
Aug 27, 2024
| some fn | ||
| ast.function_calls[_][fn].name == "sprintf" | ||
|
|
||
| fn.args[1].type == "array" # can only check static arrays, not vars |
There was a problem hiding this comment.
😱 that's a possibility... sprintf("%s %s %d", input) etc. what a nightmare
srenatus
reviewed
Aug 27, 2024
| # don't match | ||
| report contains violation if { | ||
| some fn | ||
| ast.function_calls[_][fn].name == "sprintf" |
There was a problem hiding this comment.
This looks expensive. Have you ever tried using an reverse-index here? Like "all locations where function sprintf is used"
There was a problem hiding this comment.
I think we've mostly paid the cost at this point, as ast.function_calls essentially filters ast.found.refs keeping only function calls, and then providing them in compact format nicer to work with.
But yeah, ast.found.refs is a beast, and as I'm sure you remember, I tried to collect more types in that traversal, and things... broke :P
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Fixes StyraInc#1009 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009